dns_yc: fix key handling and unify add/rm key preparation#6783
Closed
zhuravlev-nik wants to merge 2 commits intoacmesh-official:masterfrom
Closed
dns_yc: fix key handling and unify add/rm key preparation#6783zhuravlev-nik wants to merge 2 commits intoacmesh-official:masterfrom
zhuravlev-nik wants to merge 2 commits intoacmesh-official:masterfrom
Conversation
added 2 commits
February 11, 2026 18:22
Do not delete user-provided YC_SA_Key_File_Path. Prepare key file in dns_yc_rm same as dns_yc_add. Use mktemp for PEM_b64 key. Cleanup via trap.
|
Welcome |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously:
which deleted user-provided key files when using
YC_SA_Key_File_Path.
dns_yc_add(), which could lead to inconsistent behavior
depending on call order.
Changes:
from YC_SA_Key_File_PEM_b64.
The change is backward compatible and preserves existing
configuration behavior.